Re: Possible memory leak in net/wireless/scan.c
- From: Catalin Marinas <catalin.marinas@xxxxxxx>
- Date: Tue, 07 Jul 2009 22:29:28 +0100
On Tue, 2009-07-07 at 19:12 +0200, Johannes Berg wrote:
On Tue, 2009-07-07 at 18:04 +0100, Catalin Marinas wrote:
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index e95b638..f8e71b3 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -366,7 +366,6 @@ cfg80211_bss_update(struct cfg80211_registered_device *dev,
found = rb_find_bss(dev, res);
if (found) {
- kref_get(&found->ref);
found->pub.beacon_interval = res->pub.beacon_interval;
found->pub.tsf = res->pub.tsf;
found->pub.signal = res->pub.signal;
I'll try this later today to see if it fixes the leak. If that's not
correct, I'll post more information about the content of the reported
object (in general, it shouldn't be on any valid list or rb tree since
kmemleak can't find it).
I have already sent that exact patch.
OK. I can now confirm that it fixes the memory leak.
Thanks.
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: Possible memory leak in net/wireless/scan.c
- From: Johannes Berg
- Re: Possible memory leak in net/wireless/scan.c
- References:
- Possible memory leak in net/wireless/scan.c
- From: Catalin Marinas
- Re: Possible memory leak in net/wireless/scan.c
- From: Johannes Berg
- Possible memory leak in net/wireless/scan.c
- Prev by Date: Re: [PATCH -tip -v10 7/7] tracing: add kprobe-based event tracer
- Next by Date: Re: Possible memory leak via inotify_add_watch
- Previous by thread: Re: Possible memory leak in net/wireless/scan.c
- Next by thread: Re: Possible memory leak in net/wireless/scan.c
- Index(es):
Relevant Pages
|
