Re: [PATCH] move orion_nand's probe function to .devinit.text

Hi Nicolas,

On Mon, Jul 13, 2009 at 03:37:23PM -0400, Nicolas Pitre wrote:
On Sat, 11 Jul 2009, Uwe Kleine-König wrote:

A pointer to orion_nand_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

For those kind of platform devices I'd prefer the alternative.
Can I interpret that as your intend to implement and test it?

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages
Loading