[PATCH] Document pci_ids.h addition policy.
- From: Dave Jones <davej@xxxxxxxxxx>
- Date: Thu, 6 Aug 2009 15:13:59 -0400
On Thu, Aug 06, 2009 at 11:33:26AM -0700, Greg Kroah-Hartman wrote:
I agree. In fact, I'd go further, and say that the bulk of what we have
in pci_ids.h is also pointlessly shared. Only a tiny fraction of the device
entries in that file are used by multiple files in the kernel.
I agree with that as well, which is why when I was PCI maintainer, I
didn't allow any new additions to the pci_ids.h file, unless it was
going to be an id that was shared by different drivers. That cut the
new additions down to about none :)
Perhaps documenting this is a good idea to prevent things being moved there,
as it still seems to be happening judging from the git log.
Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 73b46b6..f9156fd 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2,6 +2,9 @@
* PCI Class, Vendor and Device IDs
*
* Please keep sorted.
+ *
+ * Do not add new entries to this file unless the definitions
+ * are shared between multiple drivers.
*/
/* Device classes and subclasses */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] Document pci_ids.h addition policy.
- From: Jesse Barnes
- Re: [PATCH] Document pci_ids.h addition policy.
- From: Greg KH
- Re: [PATCH] Document pci_ids.h addition policy.
- From: John W. Linville
- Re: [PATCH] Document pci_ids.h addition policy.
- References:
- [PATCH] pci_ids.h: add new Atheros USB vendor ID
- From: Luis R. Rodriguez
- Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
- From: Marcel Holtmann
- Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
- From: Luis R. Rodriguez
- Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
- From: Marcel Holtmann
- Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
- From: Greg KH
- Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
- From: Dave Jones
- Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
- From: Greg KH
- [PATCH] pci_ids.h: add new Atheros USB vendor ID
- Prev by Date: Re: [PATCH 0/3] [GIT PULL][2.6.31] ring-buffer/tracing: various fixes
- Next by Date: RE: How to efficiently handle DMA and cache on ARMv7 ? (was "Is get_user_pages() enough to prevent pages from being swapped out ?")
- Previous by thread: Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
- Next by thread: Re: [PATCH] Document pci_ids.h addition policy.
- Index(es):
Relevant Pages
|
