Re: [PATCH] dac960: switch to seq_file

On Tue, Sep 01, 2009 at 04:27:35PM -0700, Andrew Morton wrote:
On Fri, 28 Aug 2009 23:58:14 +0400
Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

drivers/block/DAC960.c | 156 ++++++++++++++++++++++---------------------------

hm, that's a large change to a hard-to-change driver.

Is it correct?

Nobody knows :-)

In fact I'm pretty sure conversion is correct:
0) ->data is passed as m->private,
1) DAC960_ProcReadStatus() -- print "OK" or "ALERT" if one controller is in alert mode,
2) DAC960_ProcReadInitialStatus() -- print ->CombinedStatusBuffer content, lenght is in ->CurrentStatusLength
3) DAC960_ProcReadUserCommand() -- (2) applied to ->UserStatusBuffer

"%.*s" does exactly that.

4) DAC960_ProcWriteUserCommand() -- signature change to ->write method, controller is in PDE(...)->data
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Paper on early space programs
    ... of useful hardware that would have made the conversion rather easier. ... The Aft Cargo Carrier did have some problems -- the sonic environment was ... reluctance to mess with the basic shuttle hardware. ... nobody had such a payload. ...
    (sci.space.history)
  • Re: Gas vs. oil? ? ?
    ... oil-burning furnace from oil to gas. ... I would welcome the experience of others who have made this conversion, ... Nobody can know what you will save, nobody knows what you pay for Ng ...
    (alt.home.repair)
  • Re: Who is supporting the Software Development Tools
    ... Also have done detective work in similar situations I am even more ... Does nobody need a decent debug package ... Castle have the source code to that as well. ... Precisely, and it is not only the 32-bit conversion, it also needs to ...
    (comp.sys.acorn.misc)
  • Re: [PATCH] dac960: switch to seq_file
    ... Alexey Dobriyan wrote: ... that's a large change to a hard-to-change driver. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
Loading