Re: No more bits in vm_area_struct's vm_flags.

On Mon, 28 Sep 2009 14:37:48 +1000
Nigel Cunningham <ncunningham@xxxxxxxxxxx> wrote:

Hi.

KAMEZAWA Hiroyuki wrote:
Then, Nigel, you have 2 choices I think.

(1) don't merge if vm_hints is set or (2) pass vm_hints to all
__merge() functions.

One of above will be accesptable for stakeholders... I personally
like (1) but just trying (2) may be accepted.

What I dislike is making vm_flags to be long long ;)

Okay. I've gone for option 1 for now. Here's what I
currently have (compile testing as I write)...



vm_flags in struct vm_area_struct is full. Move some of the less commonly
used flags to a new variable so that other flags that need to be in vm_flags
(because, for example, they need to be in variables that are passed around)
can be added.

Signed-off-by: Nigel Cunningham <nigel@xxxxxxxxxxxx>

Seems good to me.

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
But
+ if (vma->vm_hints)
+ return 0;
return 1;

Maybe adding a comment (or more detailed patch description) is necessary.

Regards,
-Kame

}

--
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages