Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

Am Dienstag 29 September 2009 15:09:50 schrieb Amit Shah:
Great, thanks. However I was thinking of moving this init to the probe()
routine instead of in the init_conosle routine just because multiple
consoles can be added and we don't want to init this each time.. just
once in probe is fine.

If you have new patch CC me and I can give it a spin.


I am a bit reluctant to Ack the whole change, since my preference would
have been to not merge virtio serial/console and instead keeping both
separate. We have already managed to clutter all other virtio drivers
with tons of configuration stuff and feature bits - and every driver uses
a different model for configuration and commands (feature bits, config
space, config_change indication, extra config virtqueue, commands
embedded into the data....). Using a different device ID for a different
use seem like a better way to me.

Well, Anthony described your objection as a comment in passing and that
you weren't strongly against merging the two drivers when I brought up
your argument sometime back.

Also, it was difficult to make progress and just keep fighting about
these issues. So even though I didn't like merging the stuff, I had to.

Sure, you were caught between two stools... I have to admit that I dropped of
this discussion and did not follow up - I simply considered my wedding and
honeymoon more important ;-)

I still belive that I am right and Anthony is wrong about this 8-), but if
merging is the way to go - so be it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages