Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only
- From: Theodore Tso <tytso@xxxxxxx>
- Date: Mon, 5 Oct 2009 10:01:18 -0400
On Mon, Oct 05, 2009 at 02:24:09PM +0200, Jan Kara wrote:
On Sat 03-10-09 23:12:38, Theodore Ts'o wrote:
This avoids updating the superblock write time when we are mountingThanks, the patch is queued in my queue already. I just held it for a
the root file system read/only but we need to replay the journal; at
that point, for people who are east of GMT and who make their clock
tick in localtime for Windows bug-for-bug compatibility, and this will
cause e2fsck to complain and force a full file system check.
while because Eric also had a valid point - maybe fsck is too strict when
it forces a full filesystem check just because the superblock write time is
in future? On a pc-class hw, clocks go often wrong. Even I remember setting
system clock on my desktop a few hours back because it just gets out of
sync and I don't run NTP...
So I'm not against your patch because it can help in some cases and
it's not a big deal but I think a proper fix would be in fsck...
Regardless of whether fsck relaxes its check, if the filesystem is
mounted read-only, I don't think the last write time should change...
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Prev by Date: Re: [PATCH v2] NFS: introduce writeback wait queue
- Next by Date: Re: futex question
- Previous by thread: Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only
- Next by thread: Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only
- Index(es):
Relevant Pages
|
