RE: [PATCH -next] ia64/sn: fix percpu warnings



DEFINE_PER_CPU(struct list_head [NR_SOFTIRQS], softirq_work_list);
EXPORT_PER_CPU_SYMBOL(softirq_work_list);

and it doesn't cause any warning on x86 neither does it on ia64 with
defconfig. softirq_work_list doesn't trigger any warning there,
right?

Of the 10 EXPORT_PER_CPU_SYMBOL and 4 EXPORT_PER_CPU_SYMBOL_GPL
items on ia64, only __sn_cnodeid_to_nasid and softirq_work_list are
arrays. The latter appears not to be actually used by any in-tree
modules (janitors: does it need to be exported?).

The CRC warning only shows up on a module that uses an exported
per-cpu array. There seems to be nothing special about the
__sn_cnodeid_to_nasid. When I hacked a module to make a random
use of softirq_work_list, it too gave a CRC error.

I just tried an x86_64 build with a module also modified to access
softirq_work_list. It did NOT get a CRC error. So the x86_64
toolchain doesn't seem to have the same issue as ia64.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: How can I cast to an array type?
    ... out how to cast the char* to the array type to remove the warning. ... the compiler is warning you about a conversion ... between incompatible pointer types. ... Arrays are usually manipulated via a pointer to the ...
    (comp.lang.c)
  • Re: Opinions? Is it _GOOD_ that foreach() throws warning when given undef var?
    ... > I was just wondering what popular opinion is on PHP giving this warning: ... > - declare as arrays the vars which will receive arrays from functions ...
    (comp.lang.php)
  • Re: Warning on assigning a function-returning-a-pointer-to-arrays
    ... the warning didn't go away. ... int(pointer to array of 5 int), or you can change the caller so ... it assigns the int* result to an int* variable. ... points to arrays are rarely useful. ...
    (comp.lang.c)
  • Re: array of lists
    ... Seems there is lots of discussion on the creation of generic arrays in ... With generics there is little use for arrays of ... If the compiler is making a noise, ... A warning is exactly that, ...
    (comp.lang.java.programmer)
  • Re: Opinions? Is it _GOOD_ that foreach() throws warning when given undef var?
    ... > I was just wondering what popular opinion is on PHP giving this warning: ... > It makes sense to me to warn if an unacceptably defined var is passed but ... > - declare as arrays the vars which will receive arrays from functions ...
    (comp.lang.php)