Re: [RFC 0/6] Driver core: Encourage use of const attributes

On 18/12/09 00:16 +0100, ext Greg KH wrote:
On Thu, Dec 17, 2009 at 08:12:10PM +0200, Phil Carmody wrote:
[...]> > So here I offer a small patchset which I hope will permit and
encourage device and other attributes to be made const, and put
in read-only sections.

1-3 address the three attribute types which seemed to be trivially
const-able, and are the important part of the set.

I like these, very nice.

Thanks, I can possibly sniff a little bit deeper, and see if there are
any other obvious throwing-away-of-consts nearby.

4 adds a new macro to encourage the use of Const ATTRibutes,
and may need a better name. (I wanted to avoid RO, for example.)

Hm, is this really needed? How badly do things break if you change the
current attribute macros to use 'const'? What subsystems are not using
const?

That was the first thing that went through my mind, but I didn't want
to be too brave. He who dares wins though, and I can certainly give
that a try. allmodconfig is my friend.

5 and 6 are merely two quick examples of how easy it is to adopt
the new const convention. In reality, these structures have been
constant and treated as constant by the driver core all along, it's
just that one word was missing from a few important places.

I would hope to submit a patchset with 1-3 and a possibly modified
4. The migrations themselves will belong in different trees.

I'll be glad to take 1-3 now, and queue it up for .34.

They cleave cleanly at that point, so I'll resend with a [PATCH] prefix.

Many thanks, and seasons greetings,

Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Enable macros => HD/CPU issues- help! any ideas?
    ... Excel file I've been working on, and only when macros are enabled. ... I also used Rob Bovey's code cleaner on the file. ... Const MaxRoadblockRows = 500 ... Const tSuffix As String = ".txt" ...
    (microsoft.public.excel.programming)
  • Re: how do I increment a numbering system in excel
    ... Const sAPPLICATION As String = "Excel" ... Const sSECTION As String = "Invoice" ... Dim nNumber As Long ... Also see David McRitchie's 'Getting Started With Macros And User Defined ...
    (microsoft.public.excel.misc)
  • Re: [PATCH] fix warning about duplicate const
    ... > macros, but memory fails me. ... The warnings the extra "const" fixes is something like: ... where otherwise it would complain about pointers to different types when ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Inconsistency in ioread functions, const pointer or not
    ... The old ioreadx routines have been macros using the appropriate readx ... Any pointer to discussions about removing const would be helpful. ...
    (Linux-Kernel)
  • Re: [RFC 0/6] Driver core: Encourage use of const attributes
    ... current attribute macros to use 'const'? ... What subsystems are not using ... That was the first thing that went through my mind, ... I'll be glad to take 1-3 now, and queue it up for .34. ...
    (Linux-Kernel)