Re: [PATCH] [4/6] kfifo: add kfifo_out_peek

On Mon, 28 Dec 2009 00:41:37 +0100
Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

On Sun, Dec 27, 2009 at 10:49:49PM +0100, Stefani Seibold wrote:
Am Sonntag, den 27.12.2009, 22:03 +0100 schrieb Andi Kleen:
In some upcoming code it's useful to peek into a FIFO without
permanentely removing data. This patch implements a new
kfifo_out_peek() to do this.


Yes this function can be useful. I will implement it in the macro
version of the kfifo.

Well that doesn't help me -- I need a working kfifo on a 2.6.33
base. Or do you want to abandon the old interface?

I must say I'm a little surprised by the general tone of
your comments -- first you submit these patches all the time and when they
finally get reviewed and merged and people start to use them and make them
production ready you state it's all abandoned.

Yup, the first priority is to get the 2.6.33 code fixed up. It is
unwise to assume that we'll be merging some other patch some time in
the future.

Macros are unpopular, for good reasons. But the case for a
template-based container such as this is a good one. However I worry
about the code bloat whcih the macro version might add. We worry about
all this later on.


Anyways Andrew could you please merge these fixes? Thanks.

I shall. Stefani, pelase review those patches for 2.6.33 suitability.
Let's not worry about a big rewrite at this time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH] [4/6] kfifo: add kfifo_out_peek
    ... template-based container such as this is a good one. ... However I worry ... about the code bloat whcih the macro version might add. ... Bloat is going to be a big issue if its macro and all the serial/tty ...
    (Linux-Kernel)
  • Re: [RFC] x86: save_args out of line
    ... The macro "interrupt" in entry_64.S generates a lot of code. ... patch moves most of its contents into an external function. ... I liked this way of calling an external function, ... rbp register with the return address directly on top of it. ...
    (Linux-Kernel)
  • Re: [PATCH 14/19] drivers/scsi: Use PCI_VDEVICE
    ... You might look at the 0/19 patch description. ... A single macro can't use both a named constant and a magic number ... named constants, mostly defined in pci_ids.h ... it doesn't seem to be an improvement over the bare initialiser ...
    (Linux-Kernel)
  • RE: AHCI - remove probing of ata2
    ... I've tested your patch yesterday, but no luck, I can't find any difference ... in the resulting boot log. ... Here's what I worry about. ... that I can test patches on this machine if people need me to do so. ...
    (Linux-Kernel)
  • Re: A question about defining fields in a text list of records
    ... Don't worry about a macro... ... formatting - that can all be added once the data is imported to Excel. ... Name: John Smith ...
    (microsoft.public.mac.office.word)