[028/197] sh: Enable the mmu in start_secondary()
- From: Greg KH <gregkh@xxxxxxx>
- Date: Thu, 22 Apr 2010 12:07:59 -0700
2.6.32-stable review patch. If anyone has any objections, please let us know.
------------------
From: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
commit 4bea3418c737891894b9d3d3e9f8bbd67d66fa38 upstream.
For the boot, enable_mmu() is called from setup_arch() but we don't call
setup_arch() for any of the other cpus. So turn on the non-boot cpu's
mmu inside of start_secondary().
I noticed this bug on an SMP board when trying to map I/O memory
(smsc911x registers) into the kernel address space. Since the Address
Translation bit in MMUCR wasn't set, accessing the virtual address where
the smsc911x registers were supposedly mapped actually performed a
physical address access.
Signed-off-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
Signed-off-by: Paul Mundt <lethal@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
--- a/arch/sh/kernel/smp.c
+++ b/arch/sh/kernel/smp.c
@@ -69,6 +69,7 @@ asmlinkage void __cpuinit start_secondary(void)
unsigned int cpu;
struct mm_struct *mm = &init_mm;
+ enable_mmu();
atomic_inc(&mm->mm_count);
atomic_inc(&mm->mm_users);
current->active_mm = mm;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [000/197] 2.6.32.12-stable review
- From: Greg KH
- [000/197] 2.6.32.12-stable review
- Prev by Date: [027/197] xfs: fix locking for inode cache radix tree tag updates
- Next by Date: [026/197] xfs: Non-blocking inode locking in IO completion
- Previous by thread: [027/197] xfs: fix locking for inode cache radix tree tag updates
- Next by thread: [026/197] xfs: Non-blocking inode locking in IO completion
- Index(es):
Relevant Pages
|