Bug in isdn_net / isdn_tty writes verbose messages to syslog ?

• Previous message: Kasper Dupont: "Re: Simulating time for a different linux process."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Date: Wed, 18 Aug 2004 18:11:18 +0200

Hi,

I'm using SuSE Linux 9.0 and isdn4linux.

A few days ago, I recognized that isdn4linux logs ignored calls to syslog.
Normally isdnlog is used to configure the log behaviour. It is also against
any privacy policies to log phonenumbers of other subscribers who use the
same isdn-bus (and different msn).

The message looks like:
"isdn_net: call from 123456 -> 0 1234567 ignored"

At the beginning I thought the verbose mode is turned on for isdn.
But it seemed to be switched on only partially, because if one switches on
verbose mode, it logs much more to syslog.

After looking at the sources, I found the following condition in isdn_net.c:

    /* If none of configured EAZ/MSN matched and not verbose, be silent */
        if (!ematch || dev->net_verbose)
                printk(KERN_INFO "isdn_net: call from %s -> %d %s
ignored\n", nr, di, eaz);

Apart from the confusing comment, to prevent isdn_net from logging to syslog
it must be:
    /* If none of configured EAZ/MSN matched and verbose switched on */
    (!ematch && dev->net_verbose)
                printk(KERN_INFO "isdn_net: call from %s -> %d %s
ignored\n", nr, di, eaz);

Is this correct ? Any other ideas ?

Christian

• Previous message: Kasper Dupont: "Re: Simulating time for a different linux process."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]